From octave-maintainers-request at bevo dot che dot wisc dot edu  Mon Nov 20 21:48:08 2000
Subject: Re: bug: 2.1.xx can't read binary files generated from 2.0.16
From: =?iso-8859-1?Q?Jo=C3=A3o?= Cardoso <jcardoso at inescn dot pt>
To: octave-maintainers at bevo dot che dot wisc dot edu
Date: Tue, 21 Nov 2000 03:52:37 +0000

"John W. Eaton" wrote:
> 
> On 20-Nov-2000, =?iso-8859-1?Q?Jo=E3o?= Cardoso <jcardoso at inescn dot pt> wrote:

...

> 
> Unfortunately, this means that anyone who has been using the current
> versions of Octave over the past 5 months or so and saving data in
> Octave's binary format will have some trouble.  I'm not sure what I
> can do about that.

Perhaps warning everybody in the lists who are using CVS to load their
binary files and save them in ascii (with enought digits to maintain
precision) *before* updating to the current (correct) octave CVS
version?

Thanks,
Joćo

PS: by the way, the current CVS sources gave an error on compilation:

load-save.cc: In function `bool save_ascii_data(ostream &, const
octave_value &, const string &, bool &, bool, bool, int)':
load-save.cc:4579: too few arguments to function `bool
save_ascii_data(ostream &, const octave_value &, const string &, bool &,
bool, bool, int)'
load-save.cc:4630: at this point in file
load-save.cc:4579: too few arguments to function `bool
save_ascii_data(ostream &, const octave_value &, const string &, bool &,
bool, bool, int)'
load-save.cc:4643: at this point in file

`bool& infnan_warned,' is missing from the call. (ignore the line
numbers, my load-save.cc is patched)

*** load-save.cc.org    Tue Nov 21 03:10:47 2000
--- load-save.cc        Tue Nov 21 03:10:50 2000
***************
*** 4626,4632 ****
            //valid_identifier doesnt let me use this one, can i change
it?
            //sprintf(s,"%s[%d]", name.c_str(), elem+1);
            sprintf(s,"%s_%d", name.c_str(), elem+1);
!           save_ascii_data ( os, ov, string(s), strip_nan_and_inf,
            mark_as_global, precision);
          }
      }
--- 4627,4633 ----
            //valid_identifier doesnt let me use this one, can i change
it?
            //sprintf(s,"%s[%d]", name.c_str(), elem+1);
            sprintf(s,"%s_%d", name.c_str(), elem+1);
!           save_ascii_data ( os, ov, string(s), infnan_warned,
strip_nan_and_in
f,
            mark_as_global, precision);
          }
      }
***************
*** 4639,4645 ****
          {
            octave_value ov = om.contents(elem);
            string s = om.key(elem);
!           save_ascii_data ( os, ov, s, strip_nan_and_inf,
            mark_as_global, precision);
          }
      }
--- 4640,4646 ----
          {
            octave_value ov = om.contents(elem);
            string s = om.key(elem);
!           save_ascii_data ( os, ov, s, infnan_warned,
strip_nan_and_inf,
            mark_as_global, precision);
          }
      }