From bug-request at octave dot org Sun Apr 16 16:21:16 2006
Subject: Re: CVS Compilation with PGI compiler
From: Paul Kienzle <pkienzle at users dot sourceforge dot net>
To: "John W. Eaton" <jwe at bevo dot che dot wisc dot edu>
Cc: "bug at octave dot org mailing list" <bug@octave.org>
Date: Sun, 16 Apr 2006 17:19:57 -0400


On Apr 16, 2006, at 3:09 PM, John W. Eaton wrote:

> On 16-Apr-2006, Christopher Hulbert wrote:
>
> | Problems with PGI compiler:
> |
> | SparseType.cc lines 95 and 418.  PGI didn't like
> | bool found [nrows] complaining nrows wasn't constant.  I'm not
> | well-versed with the C++ standard (am with the C) so I'm not sure if
> | it conforms to the standard or not.
> |
> | I fixed with:
> | bool *found = new bool[nrows];
> | ...
> | delete found /* At the end of the if block */
>
> I decided to use
>
>   std::vector<bool> found (nrows);
>
> instead.

Did you use:

	OCTAVE_LOCAL_BUFFER(bool, found, nrows)

or have we concluded that std::vector is now well supported and is
the one true way to allocate arbitrary sized local storage?

I believe it is the latter and use of OCTAVE_LOCAL_BUFFER in
octave and octave-forge should be considered cruft.

- Paul



-------------------------------------------------------------
Octave is freely available under the terms of the GNU GPL.

Octave's home on the web:  http://www.octave.org
How to fund new projects:  http://www.octave.org/funding.html
Subscription information:  http://www.octave.org/archive.html
-------------------------------------------------------------