From bug-request at octave dot org Tue Dec 13 11:49:59 2005 Subject: isequal and blkdiag problems From: "John W. Eaton" To: David dot Bateman at motorola dot com Cc: bug at octave dot org Date: Tue, 13 Dec 2005 12:49:48 -0500 On 12-Dec-2005, David Bateman wrote: | isequal.m and __isequal__.m were recently included in octave. Perhaps | the file getfield.m on which they depend should have been included at | the same time :-). blkdiag.m is also missing an octave-forge dependency | cell2mat.m but I think that might already be known... However, perhaps | the test code for blkdiag.m should be checked as running I see thinks like | | ***** assert(blkdiag(1,ones(2),1),[1,0,0,0;0,1,1,0;0,1,1,0;0,0,0,1]) | !!!!! test failed | error: unary operator `!' not implemented for `cell' operands | | the problem line appears to be | | notempty = ! cellfun ( at isempty, varargin); | | perhaps this should read | | notempty = ! cellfun ("isempty", varargin); Fixed. I think I introduced this problem when I added blkdiag.m. I didn't understand that there was a difference, but assumed that passing a character string was just another way to name a function. It seemed odd that some were passed as character strings and some were function handles, so I thought I would make them consistently use function pointers. Now I see the difference, but I think this will end up being a point of confusion in the future. jwe ------------------------------------------------------------- Octave is freely available under the terms of the GNU GPL. Octave's home on the web: http://www.octave.org How to fund new projects: http://www.octave.org/funding.html Subscription information: http://www.octave.org/archive.html -------------------------------------------------------------