From bug-request at octave dot org Fri Nov 25 01:41:29 2005 Subject: Re: isequal From: William Poetra Yoga Hadisoeseno To: bug at octave dot org Date: Fri, 25 Nov 2005 15:40:23 +0800 *NOTE*: I'm williampoetra at yahoo dot com; I'm testing gmail, and if any of you have any doubts, you can send me an email to my yahoo account. On 11/25/05, John W. Eaton wrote: > I think it would be better to use a name like "equal_nans" or > "nans_compare_equal"? It seems to me that a name like this is much > more meaningful than "_nan". > OK, nans_compare_equal seems nice ;) > | 3. Rename isequal.m to _isequal.m > > "Internal" functions in Octave should have names of the form __[a-z]__. > > | I think this function is useful for compatibility with Matlab. I was > | wrong to attach the function files last time, but now I know how to > | make a diff for new files (like what I did for blkdiag.m) and add a > | changelog entry ;) > | > | What does John think about this? > > Where is the patch? Is this the file you sent bzipped? Can you > please fix the naming and send the patch as a text/plain attachment? > It's much easier for me to handle that rather than a > bzipped/tar/zip/whatever/archive, because if it is a text/plain > attachment, I can easily view it in my mail reader inside Emacs > instead of having to save a file and unpack it, etc. > Yeah, it was in the bzipped file. OK, I'll fix the naming and resend it. I don't know, but I hope gmail can correctly identify it as plaintext (yahoo wasn't). > Since I seem to be the rate limiting step in getting changes into > Octave now, it would help speed things up if you make things as easy > as possible for me. > Sorry, it was my fault. I thought the patch would be too big, and at that time I've never tried to make a patch for a new file... I didn't mean to make it inconvenient for you :) ------------------------------------------------------------- Octave is freely available under the terms of the GNU GPL. Octave's home on the web: http://www.octave.org How to fund new projects: http://www.octave.org/funding.html Subscription information: http://www.octave.org/archive.html -------------------------------------------------------------