From bug-request at octave dot org Tue Dec 21 12:54:04 2004 Subject: Re: multiline string fix From: =?UTF-8?B?TWljaGFsIMSMaWhhxZk=?= To: "John W. Eaton" Cc: bug at octave dot org Date: Tue, 21 Dec 2004 12:43:53 -0600 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF2C2603911B3606EF48BF544 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi On 12/21/2004 06:48 PM, John W. Eaton wrote: > On 21-Dec-2004, Michal $,1 ,(Biha$,1 y(B wrote: > > | recent gcc versions reject multi line string constats, attached patch > | fixes octave compilation with them. > > Which version of GCC rejects this code? What is the precise error > message? > > There are many many more parts of Octave where string constants are > written in the style > > "foo\n\ > bar" > > which as far as I am aware is not a multi-line string constant, but a > string constant written with an escaped newline (which then > disappears). Is that not correct? > > In any case, if we really can't write strings with escaped newlines, > then I would expect many more files with problems in addition to > fsolve.cc. Perhaps there is some other explanation for the error you > saw? Does fsolve.cc have a line where the backslash at the end of the > line is followed by something other than a newline character? It looks like there was problem with some older version and the patch was still ported to newer ones without checking whether it is actually needed. It was created for 2.1.40 and looking into cvs shows, that there was missing \ at the end of few lines in that time, sorry for not needed patch (but anyway the version with one string per line looks nicer ;-). -- Best Regards, Michal Čihař developer --------------------------------------------------------------------- SuSE CR, s.r.o. e-mail: michal dot cihar at suse dot cz Drahobejlova 27 tel: +420 2 9654 2373 190 00 Praha 9 fax: +420 2 9654 2374 Czech Republic http://www.suse.cz --------------enigF2C2603911B3606EF48BF544 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFByG9t3DVS6DbnVgQRAtE6AJ9qe43h9eOhNQGIAoO/pC24REdHCgCfXZOQ lAalaKyTYS11VQim0ffJ9Kg= =scYE -----END PGP SIGNATURE----- --------------enigF2C2603911B3606EF48BF544-- ------------------------------------------------------------- Octave is freely available under the terms of the GNU GPL. Octave's home on the web: http://www.octave.org How to fund new projects: http://www.octave.org/funding.html Subscription information: http://www.octave.org/archive.html -------------------------------------------------------------