From bug-octave-request at bevo dot che dot wisc dot edu Sun Nov 16 09:31:26 2003 Subject: [patch] make statistics/base/iqr.m work with matrices From: Danilo Piazzalunga To: bug-octave at bevo dot che dot wisc dot edu Date: Sun, 16 Nov 2003 07:39:12 -0600 Bug report for Octave 2.1.50 configured for i386-pc-linux-gnu Description: -----------     The `iqr' function gives an error when its argument is a matrix, while     in documentation it is stated that it should compute the IQR for each     column. Repeat-By: ---------     octave:1> a=randn(10,6);     octave:2> iqr(a)     error: empirical_inv: data must be a vector Fix: --- This patch solves the problem. It was tested succesfully with scalars,row and column vectors, matrices (only real values -- complex values not tested). Empty matrices were not considered. --- octave/scripts/statistics/base/iqr.m        2003-11-05 04:06:15.000000000 +0100 +++ octave/scripts/statistics/base/iqr.m.new    2003-11-16 13:44:03.000000000 +0100 at @ -34,6 +34,15 @@      usage ("iqr (x)");    endif   -  y = empirical_inv (3/4, x) - empirical_inv (1/4, x); +  if (rows (x) == 1) +    x = x.'; +  endif + +  [r, c] = size(x); +  y = zeros(1, c); + +  for i = (1:c); +    y(i) = empirical_inv (3/4, x(:,i)) - empirical_inv (1/4, x(:,i)); +  endfor    endfunction Configuration (please do not edit this section): ----------------------------------------------- uname output:     Linux debian 2.4.22-1-686 #6 Sat Oct 4 14:09:08 EST 2003 i686 GNU/Linux configure opts:   '--prefix=/usr' '--datadir=/usr/share' '--libdir=/usr/lib' '--libexecdir=/usr/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-blas=/usr/lib/libblas2.so' '--with-lapack=/usr/lib/liblapack2.so' '--without-hdf5' '--with-fftw' '--with-g77=/usr/bin/g77' '--enable-shared' '--enable-rpath' '--disable-static' '--build' 'i386-linux' 'CC=/usr/bin/gcc' 'CXX=/usr/bin/g++' 'F77=/usr/bin/g77' 'build_alias=i386-linux' Fortran compiler: /usr/bin/g77 FFLAGS:           -O2 F2C:               F2CFLAGS:         FLIBS:            -L/usr/lib/gcc-lib/i486-linux/3.3.2 -L/usr/lib/gcc-lib/ i486-linux/3.3.2/../../.. -lfrtbegin -lg2c -lm -lgcc_s CPPFLAGS:         INCFLAGS:         -I. -I. -I./liboctave -I./src -I./libcruft/misc  -I./glob -I./glob C compiler:       /usr/bin/gcc, version 3.3.2 (Debian) CFLAGS:           -O2 CPICFLAG:         -fPIC C++ compiler:     /usr/bin/g++, version 3.3.2 CXXFLAGS:         -O2 CXXPICFLAG:       -fPIC LD_CXX:           /usr/bin/g++ LDFLAGS:          -s LIBFLAGS:         -L. RLD_FLAG:         -Wl,-rpath -Wl,/usr/lib/octave-2.1.50 BLAS_LIBS:        /usr/lib/liblapack2.so /usr/lib/libblas2.so FFTW_LIBS:        -lfftw LIBS:             -lreadline  -lncurses -ldl -lm LEXLIB:           LIBPLPLOT:         LIBDLFCN:         LIBGLOB:          ./glob/glob.o ./glob/fnmatch.o SED:              /bin/sed DEFS:   -DPACKAGE_NAME="" -DPACKAGE_TARNAME="" -DPACKAGE_VERSION=""   -DPACKAGE_STRING="" -DPACKAGE_BUGREPORT="" -DOCTAVE_SOURCE=1   -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1   -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1   -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1   -DHAVE_UNISTD_H=1 -DSEPCHAR=1 -DSEPCHAR_STR=":" -D__NO_MATH_INLINES=1   -DCXX_NEW_FRIEND_TEMPLATE_DECL=1 -DCXX_ISO_COMPLIANT_LIBRARY=1   -DCXX_ABI=gnu_v3 -DHAVE_LIBM=1 -DHAVE_FFTW_H=1 -DHAVE_FFTW=1   -DF77_FUNC(name,NAME)=name ## _ -DF77_FUNC_(name,NAME)=name ## __   -DHAVE_BLAS=1 -DHAVE_GETHOSTNAME=1 -DHAVE_GETPWNAM=1 -DHAVE_DEV_T=1   -DHAVE_INO_T=1 -DHAVE_NLINK_T=1 -DHAVE_NLINK_T=1 -DHAVE_LONG_LONG_INT=1   -DHAVE_UNSIGNED_LONG_LONG_INT=1 -DHAVE_SIGSET_T=1 -DHAVE_SIG_ATOMIC_T=1   -DSIZEOF_SHORT=2 -DSIZEOF_INT=4 -DSIZEOF_LONG=4 -DSIZEOF_LONG_LONG=8   -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -DNPOS=std::string::npos   -DHAVE_PLACEMENT_DELETE=1 -DHAVE_DYNAMIC_AUTO_ARRAYS=1 -DSTDC_HEADERS=1   -DHAVE_DIRENT_H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_SYS_WAIT_H=1   -DHAVE_ASSERT_H=1 -DHAVE_CURSES_H=1 -DHAVE_DLFCN_H=1 -DHAVE_FCNTL_H=1   -DHAVE_FLOAT_H=1 -DHAVE_GRP_H=1 -DHAVE_LIMITS_H=1 -DHAVE_MEMORY_H=1   -DHAVE_NCURSES_H=1 -DHAVE_POLL_H=1 -DHAVE_PWD_H=1 -DHAVE_STDLIB_H=1   -DHAVE_STRING_H=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_SYS_PARAM_H=1   -DHAVE_SYS_POLL_H=1 -DHAVE_SYS_RESOURCE_H=1 -DHAVE_SYS_SELECT_H=1   -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TIME_H=1 -DHAVE_SYS_TIMES_H=1   -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_UTSNAME_H=1 -DHAVE_TERMCAP_H=1   -DHAVE_UNISTD_H=1 -DHAVE_SSTREAM=1 -DHAVE_TERMIO_H=1 -DHAVE_SGTTY_H=1   -DHAVE_GLOB_H=1 -DHAVE_FNMATCH_H=1 -DHAVE_ATEXIT=1 -DHAVE_BASENAME=1   -DHAVE_BCOPY=1 -DHAVE_BZERO=1 -DHAVE_DUP2=1 -DHAVE_ENDGRENT=1   -DHAVE_ENDPWENT=1 -DHAVE_EXECVP=1 -DHAVE_FCNTL=1 -DHAVE_FORK=1   -DHAVE_GETCWD=1 -DHAVE_GETEGID=1 -DHAVE_GETEUID=1 -DHAVE_GETGID=1   -DHAVE_GETGRENT=1 -DHAVE_GETGRGID=1 -DHAVE_GETGRNAM=1 -DHAVE_GETPGRP=1   -DHAVE_GETPID=1 -DHAVE_GETPPID=1 -DHAVE_GETPWENT=1 -DHAVE_GETPWUID=1   -DHAVE_GETTIMEOFDAY=1 -DHAVE_GETUID=1 -DHAVE_GETWD=1 -DHAVE_KILL=1   -DHAVE_LINK=1 -DHAVE_LOCALTIME_R=1 -DHAVE_LSTAT=1 -DHAVE_MEMMOVE=1   -DHAVE_MKDIR=1 -DHAVE_MKFIFO=1 -DHAVE_MKSTEMP=1 -DHAVE_ON_EXIT=1   -DHAVE_PIPE=1 -DHAVE_POLL=1 -DHAVE_PUTENV=1 -DHAVE_RAISE=1   -DHAVE_READLINK=1 -DHAVE_RENAME=1 -DHAVE_RINDEX=1 -DHAVE_RMDIR=1   -DHAVE_SELECT=1 -DHAVE_SETGRENT=1 -DHAVE_SETPWENT=1 -DHAVE_SETVBUF=1   -DHAVE_SIGACTION=1 -DHAVE_SIGLONGJMP=1 -DHAVE_SIGPENDING=1   -DHAVE_SIGPROCMASK=1 -DHAVE_SIGSUSPEND=1 -DHAVE_STAT=1 -DHAVE_STRCASECMP=1   -DHAVE_STRDUP=1 -DHAVE_STRERROR=1 -DHAVE_STRFTIME=1 -DHAVE_STRNCASECMP=1   -DHAVE_STRPTIME=1 -DHAVE_SYMLINK=1 -DHAVE_TEMPNAM=1 -DHAVE_UMASK=1   -DHAVE_UNLINK=1 -DHAVE_USLEEP=1 -DHAVE_VFPRINTF=1 -DHAVE_VSPRINTF=1   -DHAVE_VSNPRINTF=1 -DHAVE_WAITPID=1 -DHAVE_LIBDL=1 -DHAVE_DLOPEN=1   -DHAVE_DLSYM=1 -DHAVE_DLERROR=1 -DHAVE_DLCLOSE=1 -DHAVE_DLOPEN_API=1   -DENABLE_DYNAMIC_LINKING=1 -DHAVE_TIMEVAL=1 -DHAVE_FINITE=1 -DHAVE_ISNAN=1   -DHAVE_ISINF=1 -DHAVE_COPYSIGN=1 -DHAVE_ACOSH=1 -DHAVE_ASINH=1   -DHAVE_ATANH=1 -DHAVE_ERF=1 -DHAVE_ERFC=1 -DHAVE_STRUCT_STAT_ST_BLKSIZE=1   -DHAVE_STRUCT_STAT_ST_BLOCKS=1 -DHAVE_STRUCT_STAT_ST_RDEV=1   -DHAVE_STRUCT_TM_TM_ZONE=1 -DHAVE_TM_ZONE=1 -DUSE_READLINE=1   -DEXCEPTION_IN_MATH=1 -DRETSIGTYPE=void -DSYS_SIGLIST_DECLARED=1   -DHAVE_SYS_SIGLIST=1 -DHAVE_POSIX_SIGNALS=1 -DHAVE_GETRUSAGE=1   -DHAVE_TIMES=1 -DYYTEXT_POINTER=1 -DGNUPLOT_BINARY="gnuplot"   -DGNUPLOT_HAS_FRAMES=1 User-preferences (please do not edit this section): --------------------------------------------------   EDITOR = "/usr/bin/editor"   EXEC_PATH = ":/bin:/usr/bin:/usr/X11R6/bin:/usr/local/bin"   IMAGEPATH = ".:/usr/share/octave/2.1.50/imagelib//"   INFO_FILE = "/usr/share/info/octave.info"   INFO_PROGRAM = "info"   LOADPATH = ":/usr/local/share/octave/site-m//:"   PAGER = "less -e -P'-- less ?pB(%pB\\%):--. (f)orward, (b)ack, (q)uit$'"   PS1 = "\\s:\\#> "   PS2 = "> "   PS4 = "+ "   automatic_replot = 0   beep_on_error = 0   completion_append_char = " "   default_eval_print_flag = 1 # default_global_variable_value =   default_return_value = []   default_save_format = "ascii"   define_all_return_values = 0   do_fortran_indexing = 0   echo_executing_commands = 0   empty_list_elements_ok = 1   fixed_point_format = 0   gnuplot_binary = "gnuplot"   gnuplot_command_end = "\n"   gnuplot_command_plot = "pl"   gnuplot_command_replot = "rep"   gnuplot_command_splot = "sp"   gnuplot_command_title = "t"   gnuplot_command_using = "u"   gnuplot_command_with = "w"   gnuplot_has_frames = 1   history_file = "/home/danilo/.octave_hist"   history_size = 1024   ignore_function_time_stamp = "system"   implicit_num_to_str_ok = 0   implicit_str_to_num_ok = 0   initialize_global_variables = 0   max_recursion_depth = 256   ok_to_lose_imaginary_part = "warn"   output_max_field_width = 10   output_precision = 5   page_output_immediately = 0   page_screen_output = 1   prefer_column_vectors = 1   print_answer_id_name = 1   print_empty_dimensions = 1   print_rhs_assign_val = 0   propagate_empty_matrices = 1   resize_on_range_error = 1   return_last_computed_value = 0   save_precision = 15   saving_history = 1   silent_functions = 0   split_long_rows = 1   string_fill_char = " "   struct_levels_to_print = 2   suppress_verbose_help_message = 0   treat_neg_dim_as_zero = 0   warn_assign_as_truth_value = 1   warn_divide_by_zero = 1   warn_function_name_clash = 1   warn_future_time_stamp = 1   warn_missing_semicolon = 0   warn_variable_switch_label = 0   whitespace_in_literal_matrix = ------------------------------------------------------------- Octave is freely available under the terms of the GNU GPL. Octave's home on the web: http://www.octave.org How to fund new projects: http://www.octave.org/funding.html Subscription information: http://www.octave.org/archive.html -------------------------------------------------------------